Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of ECC modules & SRAM #22

Merged
merged 6 commits into from
May 3, 2024
Merged

Cleanup of ECC modules & SRAM #22

merged 6 commits into from
May 3, 2024

Conversation

micprog
Copy link
Member

@micprog micprog commented May 2, 2024

No description provided.

@micprog micprog requested a review from yvantor May 2, 2024 12:12
@micprog micprog force-pushed the michaero/cleanup branch from cc91017 to 017d245 Compare May 2, 2024 12:28
@micprog micprog force-pushed the michaero/cleanup branch from 017d245 to 70e5318 Compare May 2, 2024 12:50
@micprog micprog requested a review from Aquaticfuller May 3, 2024 09:27
yvantor
yvantor requested changes May 3, 2024
View reviewed changes
Copy link

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left just one comment on the ecc_sram parametrization and for this I am marking this as "Request changes", but overall looks good!

rtl/ecc_wrap/ecc_sram.sv Outdated Show resolved Hide resolved
@micprog micprog force-pushed the michaero/cleanup branch from 4ef261b to 4d2c2a3 Compare May 3, 2024 10:58
@micprog micprog merged commit 2617636 into master May 3, 2024
3 checks passed
@micprog micprog deleted the michaero/cleanup branch May 3, 2024 13:24
@micprog micprog mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvantor yvantor yvantor approved these changes

@Aquaticfuller Aquaticfuller Awaiting requested review from Aquaticfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micprog @yvantor